Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>,  Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org,  gdb-patches@sources.redhat.com,
	 Nick Roberts <nickrob@snap.net.nz>,
	 Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [RFC/RFA] -break-insert -d
Date: Fri, 30 Jan 2009 16:30:00 -0000	[thread overview]
Message-ID: <200901301925.29099.vladimir@codesourcery.com> (raw)
In-Reply-To: <200901261751.38003.pedro@codesourcery.com>

On Monday 26 January 2009 20:51:37 Pedro Alves wrote:
> On Monday 26 January 2009 13:14:24, Vladimir Prus wrote:
> > 
> > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed
> > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint
> > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So,
> > there's a window when the breakpoint is inserted in the target. One possible solution is
> > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing
> > has to be done in every frontend, and GDB-side solution is better. The below patch implements
> > new -d option to the -break-insert command, which causes the newly created breakpoints to be
> > disabled.
> > 
> > Is the breakpoint.c change OK. 
> 
> Looks fine to me.

Thanks. Eli, any comments on the doc bit?

Thanks,
Volodya


WARNING: multiple messages have this Message-ID

From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>,  Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org,  gdb-patches@sources.redhat.com,
	 Nick Roberts <nickrob@snap.net.nz>,
	 Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [RFC/RFA] -break-insert -d
Date: Fri, 30 Jan 2009 16:39:00 -0000	[thread overview]
Message-ID: <200901301925.29099.vladimir@codesourcery.com> (raw)
Message-ID: <20090130163900.mZIBA4aT8DG66-n8X6GGLm0ZbOyud9ZajtZEyN4ZJz0@z> (raw)
In-Reply-To: <200901261751.38003.pedro@codesourcery.com>

On Monday 26 January 2009 20:51:37 Pedro Alves wrote:
> On Monday 26 January 2009 13:14:24, Vladimir Prus wrote:
> > 
> > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed
> > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint
> > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So,
> > there's a window when the breakpoint is inserted in the target. One possible solution is
> > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing
> > has to be done in every frontend, and GDB-side solution is better. The below patch implements
> > new -d option to the -break-insert command, which causes the newly created breakpoints to be
> > disabled.
> > 
> > Is the breakpoint.c change OK. 
> 
> Looks fine to me.

Thanks. Eli, any comments on the doc bit?

Thanks,
Volodya


  parent reply	other threads:[~2009-01-30 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 13:14 Vladimir Prus
2009-01-26 18:47 ` Pedro Alves
2009-01-26 17:50   ` Pedro Alves
2009-01-30 16:30   ` Vladimir Prus [this message]
2009-01-30 16:39     ` Vladimir Prus
2009-01-30 17:41     ` Eli Zaretskii
2009-01-30 17:18       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901301925.29099.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=nickrob@snap.net.nz \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox