From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18512 invoked by alias); 30 Jan 2009 16:25:27 -0000 Received: (qmail 18484 invoked by uid 22791); 30 Jan 2009 16:25:26 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Jan 2009 16:25:22 +0000 Received: (qmail 15531 invoked from network); 30 Jan 2009 16:25:20 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Jan 2009 16:25:20 -0000 From: Vladimir Prus To: Pedro Alves , Eli Zaretskii Subject: Re: [RFC/RFA] -break-insert -d Date: Fri, 30 Jan 2009 16:30:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org, gdb-patches@sources.redhat.com, Nick Roberts , Marc Khouzam References: <200901261614.25050.vladimir@codesourcery.com> <200901261751.38003.pedro@codesourcery.com> In-Reply-To: <200901261751.38003.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901301925.29099.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00536.txt.bz2 On Monday 26 January 2009 20:51:37 Pedro Alves wrote: > On Monday 26 January 2009 13:14:24, Vladimir Prus wrote: > > > > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed > > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint > > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So, > > there's a window when the breakpoint is inserted in the target. One possible solution is > > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing > > has to be done in every frontend, and GDB-side solution is better. The below patch implements > > new -d option to the -break-insert command, which causes the newly created breakpoints to be > > disabled. > > > > Is the breakpoint.c change OK. > > Looks fine to me. Thanks. Eli, any comments on the doc bit? Thanks, Volodya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18525 invoked by alias); 30 Jan 2009 16:25:27 -0000 Received: (qmail 18480 invoked by uid 22791); 30 Jan 2009 16:25:26 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Jan 2009 16:25:22 +0000 Received: (qmail 15531 invoked from network); 30 Jan 2009 16:25:20 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Jan 2009 16:25:20 -0000 From: Vladimir Prus To: Pedro Alves , Eli Zaretskii Subject: Re: [RFC/RFA] -break-insert -d Date: Fri, 30 Jan 2009 16:39:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org, gdb-patches@sources.redhat.com, Nick Roberts , Marc Khouzam References: <200901261614.25050.vladimir@codesourcery.com> <200901261751.38003.pedro@codesourcery.com> In-Reply-To: <200901261751.38003.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200901301925.29099.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00537.txt.bz2 Message-ID: <20090130163900.mZIBA4aT8DG66-n8X6GGLm0ZbOyud9ZajtZEyN4ZJz0@z> On Monday 26 January 2009 20:51:37 Pedro Alves wrote: > On Monday 26 January 2009 13:14:24, Vladimir Prus wrote: > > > > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed > > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint > > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So, > > there's a window when the breakpoint is inserted in the target. One possible solution is > > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing > > has to be done in every frontend, and GDB-side solution is better. The below patch implements > > new -d option to the -break-insert command, which causes the newly created breakpoints to be > > disabled. > > > > Is the breakpoint.c change OK. > > Looks fine to me. Thanks. Eli, any comments on the doc bit? Thanks, Volodya