From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: teawater <teawater@gmail.com>
Subject: Re: [RFA] Submit process record and replay third time, 3/9
Date: Fri, 23 Jan 2009 15:34:00 -0000 [thread overview]
Message-ID: <200901231535.17239.pedro@codesourcery.com> (raw)
In-Reply-To: <daef60380901230656p261655f2r6e6744d7cf4924de@mail.gmail.com>
On Friday 23 January 2009 14:56:03, teawater wrote:
> Do you think I need change:
> if (record_debug > 1)
> {
> fprintf_unfiltered (gdb_stdlog,
> "Process record: record_arch_list_add 0x%s.\n",
> paddr_nz ((CORE_ADDR)rec));
> }
> to:
> if (record_debug > 1)
> fprintf_unfiltered (gdb_stdlog,
> "Process record: record_arch_list_add 0x%s.\n",
> paddr_nz ((CORE_ADDR)rec));
Yes, thank you, but please be sure to keep correct tab/spacing.
But..., I just noticed that ``rec'' is a pointer to memory in GDB.
Don't ever cast those to CORE_ADDR, which is *target* address.
If you think these debug messages are important to keep, then please
change this and all similar cases to use host_address_to_string
instead of paddr*.
--
Pedro Alves
next prev parent reply other threads:[~2009-01-23 15:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 5:46 teawater
2009-01-13 3:06 ` teawater
2009-01-20 18:32 ` Marc Khouzam
2009-01-20 19:47 ` Marc Khouzam
2009-01-21 0:20 ` teawater
2009-01-21 2:53 ` teawater
2009-01-22 13:23 ` Pedro Alves
2009-01-22 15:23 ` teawater
2009-01-22 22:33 ` Pedro Alves
2009-01-22 22:36 ` Pedro Alves
2009-01-23 0:00 ` teawater
2009-01-23 6:58 ` teawater
2009-01-23 14:56 ` teawater
2009-01-23 15:34 ` Pedro Alves [this message]
2009-01-23 15:55 ` teawater
2009-02-02 9:05 ` teawater
2009-02-08 13:03 ` teawater
2009-02-17 7:12 ` teawater
2009-02-17 7:21 ` teawater
2009-02-23 16:05 ` teawater
2009-03-03 20:40 ` Pedro Alves
2009-03-04 3:42 ` teawater
2009-03-09 6:01 ` teawater
2009-03-09 19:31 ` Pedro Alves
2009-03-10 17:03 ` teawater
2009-03-09 20:35 ` Pedro Alves
2009-03-10 17:32 ` teawater
2009-03-10 19:35 ` Pedro Alves
2009-03-11 1:15 ` teawater
2009-03-13 0:27 ` teawater
2009-03-16 11:21 ` teawater
2009-03-18 8:50 ` teawater
2009-03-18 13:12 ` teawater
2009-03-18 13:05 ` teawater
2009-03-18 13:14 ` teawater
2009-03-18 13:54 ` teawater
2009-02-23 14:08 ` teawater
2009-02-28 10:02 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901231535.17239.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox