From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61295-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24430 invoked by alias); 23 Jan 2009 15:34:24 -0000
Received: (qmail 24418 invoked by uid 22791); 23 Jan 2009 15:34:22 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Jan 2009 15:34:17 +0000
Received: (qmail 2456 invoked from network); 23 Jan 2009 15:34:14 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 23 Jan 2009 15:34:14 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Submit process record and replay third time, 3/9
Date: Fri, 23 Jan 2009 15:34:00 -0000
User-Agent: KMail/1.9.10
Cc: teawater <teawater@gmail.com>
References: <daef60380901072146w727f7abat7ff7738a03e58d23@mail.gmail.com> <200901221324.02225.pedro@codesourcery.com> <daef60380901230656p261655f2r6e6744d7cf4924de@mail.gmail.com>
In-Reply-To: <daef60380901230656p261655f2r6e6744d7cf4924de@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901231535.17239.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00465.txt.bz2

On Friday 23 January 2009 14:56:03, teawater wrote:

> Do you think I need change:
>   if (record_debug > 1)
>     {
>       fprintf_unfiltered (gdb_stdlog,
> 			  "Process record: record_arch_list_add 0x%s.\n",
> 			  paddr_nz ((CORE_ADDR)rec));
>     }
> to:
>   if (record_debug > 1)
>       fprintf_unfiltered (gdb_stdlog,
> 			  "Process record: record_arch_list_add 0x%s.\n",
> 			  paddr_nz ((CORE_ADDR)rec));

Yes, thank you, but please be sure to keep correct tab/spacing.

But..., I just noticed that ``rec'' is a pointer to memory in GDB.
Don't ever cast those to CORE_ADDR, which is *target* address.

If you think these debug messages are important to keep, then please
change this and all similar cases to use host_address_to_string
instead of paddr*.

-- 
Pedro Alves