Re: [RFA] Submit process record and replay third time, 3/9

[Pedro Alves <pedro@codesourcery.com>]

Hi Hui,

Sorry for the delay in getting back to this.

On Monday 23 February 2009 09:20:13, teawater wrote:

> ---
>  gdbarch.sh |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/gdbarch.sh
> +++ b/gdbarch.sh
> @@ -709,6 +709,10 @@ F:char *:static_transform_name:char *nam
>  # Set if the address in N_SO or N_FUN stabs may be zero.
>  v:int:sofun_address_maybe_missing:::0:0::0
>  
> +# For the process record and replay target.
> +M:int:process_record:CORE_ADDR addr:addr

You'll need to extend this comment a little further.  What is this
callback really for?  E.g., what is it supposed to do?  These things
should be documented here.

About the interface itself, would it be possible to adjust the
interface to make this callback's implementations not call record.c
functions, but instead have record.c work only with the results of
this callback?

> +M:void:process_record_dasm:void
> +

I'm puzzled by this one.  What's this for?  I can't see it being
used anywhere, did I miss something?  What's "dasm"?  If its not
used for anything yet, let's remove it for now.

-- 
Pedro Alves