From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value
Date: Thu, 15 Jan 2009 15:40:00 -0000 [thread overview]
Message-ID: <200901151539.n0FFdpFB015359@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090114172731.GA4480@caradoc.them.org> from "Daniel Jacobowitz" at Jan 14, 2009 12:27:31 PM
Daniel Jacobowitz wrote:
> On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote:
> >
> > > ChangeLog:
> > >
> > > * value.h (address_of_variable): Add prototype.
> > > (locate_var_value): Remove prototype.
> > >
> > > * findvar.c (read_var_value): Do not attempt to default frame
> > > to selected frame.
> > > (locate_var_value): Remove function.
> > > * valops.c (value_of_variable): Retrieve selected frame for
> > > symbols that require a frame when called with NULL block.
> > > * valops.c (address_of_variable): New function.
> > >
> > > * eval.c (evaluate_subexp_for_address): Call address_of_variable
> > > instead of calling locate_var_value.
> > > (evaluate_subexp_with_coercion): Likewise.
> >
> > I've noticed a couple of tests that are now obsolete. Please consider
> > the following patch instead. Re-tested on powerpc-linux.
>
> Looks reasonable to me.
Thanks for the review!
I've checked this in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2009-01-15 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 19:09 Ulrich Weigand
2009-01-14 15:32 ` Ulrich Weigand
2009-01-14 17:28 ` Daniel Jacobowitz
2009-01-15 15:40 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901151539.n0FFdpFB015359@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox