From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24087 invoked by alias); 15 Jan 2009 15:40:41 -0000 Received: (qmail 24078 invoked by uid 22791); 15 Jan 2009 15:40:40 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 15:39:54 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id n0FFdpck641578 for ; Thu, 15 Jan 2009 15:39:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0FFdqT04337728 for ; Thu, 15 Jan 2009 16:39:52 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0FFdp1K015365 for ; Thu, 15 Jan 2009 16:39:52 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n0FFdpFB015359; Thu, 15 Jan 2009 16:39:51 +0100 Message-Id: <200901151539.n0FFdpFB015359@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 15 Jan 2009 16:39:51 +0100 Subject: Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value To: drow@false.org (Daniel Jacobowitz) Date: Thu, 15 Jan 2009 15:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20090114172731.GA4480@caradoc.them.org> from "Daniel Jacobowitz" at Jan 14, 2009 12:27:31 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00355.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote: > > > > > ChangeLog: > > > > > > * value.h (address_of_variable): Add prototype. > > > (locate_var_value): Remove prototype. > > > > > > * findvar.c (read_var_value): Do not attempt to default frame > > > to selected frame. > > > (locate_var_value): Remove function. > > > * valops.c (value_of_variable): Retrieve selected frame for > > > symbols that require a frame when called with NULL block. > > > * valops.c (address_of_variable): New function. > > > > > > * eval.c (evaluate_subexp_for_address): Call address_of_variable > > > instead of calling locate_var_value. > > > (evaluate_subexp_with_coercion): Likewise. > > > > I've noticed a couple of tests that are now obsolete. Please consider > > the following patch instead. Re-tested on powerpc-linux. > > Looks reasonable to me. Thanks for the review! I've checked this in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com