From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value
Date: Wed, 14 Jan 2009 17:28:00 -0000 [thread overview]
Message-ID: <20090114172731.GA4480@caradoc.them.org> (raw)
In-Reply-To: <200901141531.n0EFVpw3021651@d12av02.megacenter.de.ibm.com>
On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote:
>
> > ChangeLog:
> >
> > * value.h (address_of_variable): Add prototype.
> > (locate_var_value): Remove prototype.
> >
> > * findvar.c (read_var_value): Do not attempt to default frame
> > to selected frame.
> > (locate_var_value): Remove function.
> > * valops.c (value_of_variable): Retrieve selected frame for
> > symbols that require a frame when called with NULL block.
> > * valops.c (address_of_variable): New function.
> >
> > * eval.c (evaluate_subexp_for_address): Call address_of_variable
> > instead of calling locate_var_value.
> > (evaluate_subexp_with_coercion): Likewise.
>
> I've noticed a couple of tests that are now obsolete. Please consider
> the following patch instead. Re-tested on powerpc-linux.
Looks reasonable to me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-01-14 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 19:09 Ulrich Weigand
2009-01-14 15:32 ` Ulrich Weigand
2009-01-14 17:28 ` Daniel Jacobowitz [this message]
2009-01-15 15:40 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114172731.GA4480@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox