From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30235 invoked by alias); 14 Jan 2009 17:28:17 -0000 Received: (qmail 30226 invoked by uid 22791); 14 Jan 2009 17:28:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jan 2009 17:27:35 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E246910632; Wed, 14 Jan 2009 17:27:32 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id C5A921053D; Wed, 14 Jan 2009 17:27:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LN9Wd-0001GL-J5; Wed, 14 Jan 2009 12:27:31 -0500 Date: Wed, 14 Jan 2009 17:28:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value Message-ID: <20090114172731.GA4480@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200901131908.n0DJ8ouI020537@d12av02.megacenter.de.ibm.com> <200901141531.n0EFVpw3021651@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901141531.n0EFVpw3021651@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00324.txt.bz2 On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote: > > > ChangeLog: > > > > * value.h (address_of_variable): Add prototype. > > (locate_var_value): Remove prototype. > > > > * findvar.c (read_var_value): Do not attempt to default frame > > to selected frame. > > (locate_var_value): Remove function. > > * valops.c (value_of_variable): Retrieve selected frame for > > symbols that require a frame when called with NULL block. > > * valops.c (address_of_variable): New function. > > > > * eval.c (evaluate_subexp_for_address): Call address_of_variable > > instead of calling locate_var_value. > > (evaluate_subexp_with_coercion): Likewise. > > I've noticed a couple of tests that are now obsolete. Please consider > the following patch instead. Re-tested on powerpc-linux. Looks reasonable to me. -- Daniel Jacobowitz CodeSourcery