Re: [2/2] Inspect extra signal information

[Pedro Alves <pedro@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Thanks Eli,

On Monday 12 January 2009 19:37:13, Eli Zaretskii write:
> Thanks, this part is approved, with the following comments:
> 
> > +@cindex inspecting extra signal information
> 
> I think just "extra signal information" is enough.

I've adjusted it.

> > +@anchor{qXfer siginfo read}
> 
> You never reference this anchor.
> 
> > +@anchor{qXfer siginfo write}
> 
> Nor this one.
> 

Ooops, copypasto.  I had made references to the wrong anchors.

I now also notice that I had placed the 'qXfer siginfo read' bits
in the write table...  I've now placed the new packets in
alphabetical order as well, while I'm at it.

I've updated the docs with the attached diff.


I also noticed that the write packets have a @var{} around the
object name, but the read ones don't:

 @item qXfer:@var{spu}:write

 @item qXfer:auxv:read
 @item qXfer:libraries:read

I copied that, but which one is the correct form?

-- 
Pedro Alves

[-- Attachment #2: eli_review.diff --]
[-- Type: text/x-diff, Size: 4148 bytes --]

---
 gdb/doc/gdb.texinfo |   48 +++++++++++++++++++++++++-----------------------
 1 file changed, 25 insertions(+), 23 deletions(-)

Index: src/gdb/doc/gdb.texinfo
===================================================================
--- src.orig/gdb/doc/gdb.texinfo	2009-01-13 11:56:10.000000000 +0000
+++ src/gdb/doc/gdb.texinfo	2009-01-13 12:22:00.000000000 +0000
@@ -4473,8 +4473,8 @@ a result of the fatal signal once it saw
 you can continue with @samp{signal 0}.  @xref{Signaling, ,Giving your
 Program a Signal}.
 
-@cindex inspecting extra signal information
-@anchor{inspecting extra signal information}
+@cindex extra signal information
+@anchor{extra signal information}
 
 On some targets, @value{GDBN} can inspect extra signal information
 associated with the intercepted signal, before it is actually
@@ -7398,7 +7398,7 @@ the program being debugged terminates.
 @item $_siginfo
 @vindex $_siginfo@r{, convenience variable}
 The variable @code{$_siginfo} is bound to extra signal information
-inspection (@pxref{inspecting extra signal information}).
+inspection (@pxref{extra signal information}).
 @end table
 
 On HP-UX systems, if you refer to a function or variable name that
@@ -26647,11 +26647,11 @@ The remote stub understands the @samp{qX
 
 @item qXfer:siginfo:read
 The remote stub understands the @samp{qXfer:siginfo:read} packet
-(@pxref{qXfer spu read}).
+(@pxref{qXfer siginfo read}).
 
 @item qXfer:siginfo:write
 The remote stub understands the @samp{qXfer:siginfo:write} packet
-(@pxref{qXfer spu write}).
+(@pxref{qXfer siginfo write}).
 
 @item QNonStop
 The remote stub understands the @samp{QNonStop} packet
@@ -26811,6 +26811,16 @@ annex part of the generic @samp{qXfer} p
 This packet is not probed by default; the remote stub must request it,
 by supplying an appropriate @samp{qSupported} response (@pxref{qSupported}).
 
+@item qXfer:siginfo:read::@var{offset},@var{length}
+@anchor{qXfer siginfo read}
+Read contents of the extra signal information on the target
+system.  The annex part of the generic @samp{qXfer} packet must be
+empty (@pxref{qXfer read}).
+
+This packet is not probed by default; the remote stub must request it,
+by supplying an appropriate @samp{qSupported} response
+(@pxref{qSupported}).
+
 @item qXfer:spu:read:@var{annex}:@var{offset},@var{length}
 @anchor{qXfer spu read}
 Read contents of an @code{spufs} file on the target system.  The
@@ -26876,6 +26886,16 @@ Here are the specific requests of this f
 formats, listed below.
 
 @table @samp
+@item qXfer:@var{siginfo}:write::@var{offset}:@var{data}@dots{}
+@anchor{qXfer siginfo write}
+Write @var{data} to the extra signal information on the target system.
+The annex part of the generic @samp{qXfer} packet must be
+empty (@pxref{qXfer write}).
+
+This packet is not probed by default; the remote stub must request it,
+by supplying an appropriate @samp{qSupported} response
+(@pxref{qSupported}).
+
 @item qXfer:@var{spu}:write:@var{annex}:@var{offset}:@var{data}@dots{}
 @anchor{qXfer spu write}
 Write @var{data} to an @code{spufs} file on the target system.  The
@@ -26886,24 +26906,6 @@ in that context to be accessed.
 
 This packet is not probed by default; the remote stub must request it,
 by supplying an appropriate @samp{qSupported} response (@pxref{qSupported}).
-
-@item qXfer:siginfo:read:@var{annex}:@var{offset},@var{length}
-@anchor{qXfer siginfo read}
-Read contents of the extra signal information on the target
-system.  The annex part of the generic @samp{qXfer} packet must be
-empty (@pxref{qXfer read}).
-
-This packet is not probed by default; the remote stub must request it,
-by supplying an appropriate @samp{qSupported} response (@pxref{qSupported}).
-
-@item qXfer:@var{siginfo}:write:@var{annex}:@var{offset}:@var{data}@dots{}
-@anchor{qXfer siginfo write}
-Write @var{data} to the extra signal information on the target system.
-The annex part of the generic @samp{qXfer} packet must be
-empty (@pxref{qXfer write}).
-
-This packet is not probed by default; the remote stub must request it,
-by supplying an appropriate @samp{qSupported} response (@pxref{qSupported}).
 @end table
 
 Reply: