Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix build breakage on arm-none-eabi
Date: Thu, 08 Jan 2009 19:20:00 -0000	[thread overview]
Message-ID: <20090108192015.GO28711@codesourcery.com> (raw)
In-Reply-To: <49664FEE.6050706@codesourcery.com>

On Thu, Jan 08, 2009 at 11:11:42AM -0800, Stan Shebs wrote:
> Nathan Froyd wrote:
> >The patch below fixes compilation.  sim/common/callback.c calls exit, so
> >I figured it was fair to make gdb_os_error call exit as well.
> >  
> This is good, thanks! (I ran into it in a checkout yesterday too.)

Thanks.  Pedro alerted me to the presence of ATTR_NORETURN; this is what
I committed instead.

-Nathan

Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.81
diff -u -r1.81 remote-sim.c
--- remote-sim.c	3 Jan 2009 05:57:53 -0000	1.81
+++ remote-sim.c	8 Jan 2009 19:17:17 -0000
@@ -70,7 +70,7 @@
 
 static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list);
 
-static void gdb_os_error (host_callback *, const char *, ...);
+static void gdb_os_error (host_callback *, const char *, ...) ATTR_NORETURN;
 
 static void gdbsim_fetch_register (struct regcache *regcache, int regno);
 
@@ -273,6 +273,7 @@
       verror (format, args);
       va_end (args);
     }
+  exit (1);
 }
 
 int


      reply	other threads:[~2009-01-08 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 18:21 Nathan Froyd
2009-01-08 19:11 ` Stan Shebs
2009-01-08 19:20   ` Nathan Froyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108192015.GO28711@codesourcery.com \
    --to=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox