From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4650 invoked by alias); 8 Jan 2009 19:20:21 -0000 Received: (qmail 4635 invoked by uid 22791); 8 Jan 2009 19:20:20 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jan 2009 19:20:17 +0000 Received: (qmail 19006 invoked from network); 8 Jan 2009 19:20:15 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Jan 2009 19:20:15 -0000 Date: Thu, 08 Jan 2009 19:20:00 -0000 From: Nathan Froyd To: gdb-patches@sourceware.org Subject: Re: [PATCH] fix build breakage on arm-none-eabi Message-ID: <20090108192015.GO28711@codesourcery.com> Mail-Followup-To: gdb-patches@sourceware.org References: <20090108182126.GM28711@codesourcery.com> <49664FEE.6050706@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49664FEE.6050706@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00170.txt.bz2 On Thu, Jan 08, 2009 at 11:11:42AM -0800, Stan Shebs wrote: > Nathan Froyd wrote: > >The patch below fixes compilation. sim/common/callback.c calls exit, so > >I figured it was fair to make gdb_os_error call exit as well. > > > This is good, thanks! (I ran into it in a checkout yesterday too.) Thanks. Pedro alerted me to the presence of ATTR_NORETURN; this is what I committed instead. -Nathan Index: remote-sim.c =================================================================== RCS file: /cvs/src/src/gdb/remote-sim.c,v retrieving revision 1.81 diff -u -r1.81 remote-sim.c --- remote-sim.c 3 Jan 2009 05:57:53 -0000 1.81 +++ remote-sim.c 8 Jan 2009 19:17:17 -0000 @@ -70,7 +70,7 @@ static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list); -static void gdb_os_error (host_callback *, const char *, ...); +static void gdb_os_error (host_callback *, const char *, ...) ATTR_NORETURN; static void gdbsim_fetch_register (struct regcache *regcache, int regno); @@ -273,6 +273,7 @@ verror (format, args); va_end (args); } + exit (1); } int