Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] fix build breakage on arm-none-eabi
Date: Thu, 08 Jan 2009 18:21:00 -0000	[thread overview]
Message-ID: <20090108182126.GM28711@codesourcery.com> (raw)

This patch:

  http://sourceware.org/ml/gdb-patches/2009-01/msg00063.html

breaks compilation on arm-none-eabi:

/scratch/froydnj/fsf/armeabi/obj/gdb-src-mainline-0-arm-none-eabi-i686-pc-linux-gnu/gdb/remote-sim.c: In function `init_callbacks':
/scratch/froydnj/fsf/armeabi/obj/gdb-src-mainline-0-arm-none-eabi-i686-pc-linux-gnu/gdb/remote-sim.c:169: warning: assignment makes qualified function pointer from unqualified

The patch below fixes compilation.  sim/common/callback.c calls exit, so
I figured it was fair to make gdb_os_error call exit as well.

OK to commit?

-Nathan

2009-01-08  Nathan Froyd  <froydnj@codesourcery.com>

	* remote-sim.c (gdb_os_error): Mark as a noreturn function.
	Call exit to make it obvious to GCC.

Index: remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.81
diff -u -u -r1.81 remote-sim.c
--- remote-sim.c	3 Jan 2009 05:57:53 -0000	1.81
+++ remote-sim.c	8 Jan 2009 18:20:26 -0000
@@ -70,7 +70,11 @@
 
 static void gdb_os_evprintf_filtered (host_callback *, const char *, va_list);
 
-static void gdb_os_error (host_callback *, const char *, ...);
+static void gdb_os_error (host_callback *, const char *, ...)
+#ifdef __GNUC__
+  __attribute__ ((__noreturn__))
+#endif
+  ;
 
 static void gdbsim_fetch_register (struct regcache *regcache, int regno);
 
@@ -273,6 +277,7 @@
       verror (format, args);
       va_end (args);
     }
+  exit (1);
 }
 
 int


             reply	other threads:[~2009-01-08 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 18:21 Nathan Froyd [this message]
2009-01-08 19:11 ` Stan Shebs
2009-01-08 19:20   ` Nathan Froyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108182126.GM28711@codesourcery.com \
    --to=froydnj@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox