Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: some news about the x86_64-windows port...
Date: Thu, 08 Jan 2009 10:31:00 -0000	[thread overview]
Message-ID: <20090108103128.GR3664@adacore.com> (raw)
In-Reply-To: <20090107165412.GB31906@ednor.casa.cgf.cx>

Hi Chris,

First, thanks very much for the ultra-fast review. It will make
the merging that much easier. Thanks a lot.

> Other than that minor nit, the windowss-specific stuff looks good to me.
> I assume that you tested that it all still worked on 32-bit windows
> right?

Yes I did. The caveat is that I tested it with AdaCore's testsuite
as I can't seem to be able to make the testsuite run smoothly on
Windows. Not sure what's going on, since I think I have the latest
of dejagnu and expect. The testsuite just keeps timing out and
never completes (that was on XP, and I have two left hands when
it comes to Windows).  On the other hand, I let it go, because
the nature of the changes I made were such that I felt safe with
just running our testsuite. Our testsuite is not as extensive as
the official one, but it does cover all the major areas I believe.

I hope this is still good enough.

> Btw, I'm sorry about all of the places where I used DWORD
> inappropriately in win32-nat.c.  I should have known better than that
> and it looks like I made your job harder.

No worries at all. What really made my job harder was actually the fact
that Microsoft decided that sizeof (long) should be 4 and not 8.
I think the reason they gave was that most legacy application that
used a long "probably" didn't need a larger long.  So they argue
that this decision should avoid some unnecessary memory waste.
I can probably find the article again, if anyone is interested.

-- 
Joel


      reply	other threads:[~2009-01-08 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 10:59 Joel Brobecker
2009-01-07 11:30 ` Mark Kettenis
2009-01-07 12:21   ` Andreas Schwab
2009-01-07 12:30     ` Mark Kettenis
2009-01-07 16:54 ` Christopher Faylor
2009-01-08 10:31   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108103128.GR3664@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox