From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19084 invoked by alias); 8 Jan 2009 10:31:42 -0000 Received: (qmail 19076 invoked by uid 22791); 8 Jan 2009 10:31:41 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jan 2009 10:31:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6DE432A9680 for ; Thu, 8 Jan 2009 05:31:36 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jZ6ZyQzyqfXD for ; Thu, 8 Jan 2009 05:31:36 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A2D992A967D for ; Thu, 8 Jan 2009 05:31:35 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A2AF5E7ACD; Thu, 8 Jan 2009 14:31:28 +0400 (RET) Date: Thu, 08 Jan 2009 10:31:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: some news about the x86_64-windows port... Message-ID: <20090108103128.GR3664@adacore.com> References: <20090107105848.GM3664@adacore.com> <20090107165412.GB31906@ednor.casa.cgf.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107165412.GB31906@ednor.casa.cgf.cx> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00140.txt.bz2 Hi Chris, First, thanks very much for the ultra-fast review. It will make the merging that much easier. Thanks a lot. > Other than that minor nit, the windowss-specific stuff looks good to me. > I assume that you tested that it all still worked on 32-bit windows > right? Yes I did. The caveat is that I tested it with AdaCore's testsuite as I can't seem to be able to make the testsuite run smoothly on Windows. Not sure what's going on, since I think I have the latest of dejagnu and expect. The testsuite just keeps timing out and never completes (that was on XP, and I have two left hands when it comes to Windows). On the other hand, I let it go, because the nature of the changes I made were such that I felt safe with just running our testsuite. Our testsuite is not as extensive as the official one, but it does cover all the major areas I believe. I hope this is still good enough. > Btw, I'm sorry about all of the places where I used DWORD > inappropriately in win32-nat.c. I should have known better than that > and it looks like I made your job harder. No worries at all. What really made my job harder was actually the fact that Microsoft decided that sizeof (long) should be 4 and not 8. I think the reason they gave was that most legacy application that used a long "probably" didn't need a larger long. So they argue that this decision should avoid some unnecessary memory waste. I can probably find the article again, if anyone is interested. -- Joel