From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org
Subject: Re: some news about the x86_64-windows port...
Date: Wed, 07 Jan 2009 16:54:00 -0000 [thread overview]
Message-ID: <20090107165412.GB31906@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20090107105848.GM3664@adacore.com>
On Wed, Jan 07, 2009 at 02:58:48PM +0400, Joel Brobecker wrote:
>-static BOOL WINAPI (*DebugSetProcessKillOnExit)(BOOL);
>-static BOOL WINAPI (*DebugActiveProcessStop)(DWORD);
>+static BOOL WINAPI (*kernel32_DebugSetProcessKillOnExit)(BOOL);
>+static BOOL WINAPI (*kernel32_DebugActiveProcessStop)(DWORD);
This seems like a gratuitous renaming. Is there some reason for it?
Other than that minor nit, the windowss-specific stuff looks good to me.
I assume that you tested that it all still worked on 32-bit windows
right?
Btw, I'm sorry about all of the places where I used DWORD
inappropriately in win32-nat.c. I should have known better than that
and it looks like I made your job harder.
cgf
next prev parent reply other threads:[~2009-01-07 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 10:59 Joel Brobecker
2009-01-07 11:30 ` Mark Kettenis
2009-01-07 12:21 ` Andreas Schwab
2009-01-07 12:30 ` Mark Kettenis
2009-01-07 16:54 ` Christopher Faylor [this message]
2009-01-08 10:31 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107165412.GB31906@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox