Re: [patch] Testsuite: Fortran: 6.8 regression + gfortran updates

[Joel Brobecker <brobecker@adacore.com>]

> I agree the indentation in general is correct.  But it is done there twice now
> - both before and after the `::' delimiter.  Indentation should happen only at
> the column 1.  For `a' variable level == 0 but for `c' and `d' level == 4:

Aha, I see. Thanks for explaining.

> gdb/
> 2009-01-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* f-typeprint.c (f_type_print_base <TYPE_CODE_STRUCT>): Fix output
> 	spacing, a regression from 2008-04-22.
> 
> gdb/testsuite/
> 2009-01-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.fortran/derived-type.exp: New variables int4 and real4.  Match
> 	now the output exactly, using less wildcards.  Expect also the output
> 	of gfortran-4.3.  Update for the f-valprint.c modification from
> 	2008-04-22.
> 	* gdb.fortran/subarray.exp: Expect also the output of gfortran-4.3.
> 	Remove gdb_test test names where matching the command.

Both OK, just one tiny comment.

> +# (gfortran-4.1|gfortran-4.3).  Other Fortran compilers would need other
> +# expect-strings.

Normally, we try to use full sentences in comments. The comment above
takes a little longer than it should to understand because you need to
read the code below to know what it's about.  In GDB, and I suspect
in the majority of GNU projects, the comments are place before the code
which can force us to repeat the code a bit sometimes... I tried to
make a suggestion but I don't know Fortran enough to help. Perhaps:

  /* Depending on the compiler version being used, the name of the 4-byte
     integer and real types can be printed differently.  For instance,
     gfortran-4.1 uses "int4" whereas gfortran-4.3 uses "int(kind=4)".  */

Dependending on how the information is encoded, the comment can probably
be improved further.

No need to re-request approval after the comment is expanded a bit.

Thanks,
-- 
Joel