Re: [patch] Testsuite: Fortran: 6.8 regression + gfortran updates

[Joel Brobecker <brobecker@adacore.com>]

> gdb/
> 2009-01-06  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* f-typeprint.c (f_type_print_base <TYPE_CODE_STRUCT>): Fix output
> 	spacing, a regression from 2008-04-22.

I am not sure about this part - the use of the "indented" printf seems
to be pretty deliberate, and we find this use elsewhere for the other
kinds of types. Looks like Fortran developers like indented type names?
I think it'd be interesting to get Markus' opinion.

This, in turn, conditions the changes to the testsuite, but it should
only be minimal.

> gdb/testsuite/
> 2009-01-06  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
>         * gdb.fortran/derived-type.exp: New variables int4 and real4.  Match
>         now the output exactly, using less wildcards.  Expect also the output
>         of gfortran-4.3.  Update for the f-valprint.c modification from
>         2008-04-22.
>         * gdb.fortran/subarray.exp: Expect also the output of gfortran-4.3.
>         Remove gdb_test test names where matching the command.

Overall, the changes look OK to me. The only adjustment that might be
needed is if we keep (f_type_print_base <TYPE_CODE_STRUCT>) as is.

-- 
Joel