From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22281 invoked by alias); 7 Jan 2009 05:14:19 -0000 Received: (qmail 22270 invoked by uid 22791); 7 Jan 2009 05:14:18 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 05:14:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 944AA2A9672; Wed, 7 Jan 2009 00:14:12 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id l6pT1UEYm3V7; Wed, 7 Jan 2009 00:14:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BB9812A9625; Wed, 7 Jan 2009 00:14:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 75BB7E7ACD; Wed, 7 Jan 2009 09:14:04 +0400 (RET) Date: Wed, 07 Jan 2009 05:14:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Markus Deuling Subject: Re: [patch] Testsuite: Fortran: 6.8 regression + gfortran updates Message-ID: <20090107051404.GI3664@adacore.com> References: <20081208181523.GA23831@host0.dyn.jankratochvil.net> <20081229034845.GF4216@adacore.com> <20090106140516.GA16916@host0.dyn.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090106140516.GA16916@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00070.txt.bz2 > gdb/ > 2009-01-06 Jan Kratochvil > > * f-typeprint.c (f_type_print_base ): Fix output > spacing, a regression from 2008-04-22. I am not sure about this part - the use of the "indented" printf seems to be pretty deliberate, and we find this use elsewhere for the other kinds of types. Looks like Fortran developers like indented type names? I think it'd be interesting to get Markus' opinion. This, in turn, conditions the changes to the testsuite, but it should only be minimal. > gdb/testsuite/ > 2009-01-06 Jan Kratochvil > > * gdb.fortran/derived-type.exp: New variables int4 and real4. Match > now the output exactly, using less wildcards. Expect also the output > of gfortran-4.3. Update for the f-valprint.c modification from > 2008-04-22. > * gdb.fortran/subarray.exp: Expect also the output of gfortran-4.3. > Remove gdb_test test names where matching the command. Overall, the changes look OK to me. The only adjustment that might be needed is if we keep (f_type_print_base ) as is. -- Joel