From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17301 invoked by alias); 7 Jan 2009 08:46:54 -0000 Received: (qmail 17291 invoked by uid 22791); 7 Jan 2009 08:46:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 08:46:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3D4A32A9618; Wed, 7 Jan 2009 03:46:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TbII56qEGQFE; Wed, 7 Jan 2009 03:46:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5B93B2A9612; Wed, 7 Jan 2009 03:46:47 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 445AEE7ACD; Wed, 7 Jan 2009 12:46:40 +0400 (RET) Date: Wed, 07 Jan 2009 08:46:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Markus Deuling Subject: Re: [patch] Testsuite: Fortran: 6.8 regression + gfortran updates Message-ID: <20090107084640.GK3664@adacore.com> References: <20081208181523.GA23831@host0.dyn.jankratochvil.net> <20081229034845.GF4216@adacore.com> <20090106140516.GA16916@host0.dyn.jankratochvil.net> <20090107051404.GI3664@adacore.com> <20090107073754.GA30904@host0.dyn.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107073754.GA30904@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00074.txt.bz2 > I agree the indentation in general is correct. But it is done there twice now > - both before and after the `::' delimiter. Indentation should happen only at > the column 1. For `a' variable level == 0 but for `c' and `d' level == 4: Aha, I see. Thanks for explaining. > gdb/ > 2009-01-07 Jan Kratochvil > > * f-typeprint.c (f_type_print_base ): Fix output > spacing, a regression from 2008-04-22. > > gdb/testsuite/ > 2009-01-07 Jan Kratochvil > > * gdb.fortran/derived-type.exp: New variables int4 and real4. Match > now the output exactly, using less wildcards. Expect also the output > of gfortran-4.3. Update for the f-valprint.c modification from > 2008-04-22. > * gdb.fortran/subarray.exp: Expect also the output of gfortran-4.3. > Remove gdb_test test names where matching the command. Both OK, just one tiny comment. > +# (gfortran-4.1|gfortran-4.3). Other Fortran compilers would need other > +# expect-strings. Normally, we try to use full sentences in comments. The comment above takes a little longer than it should to understand because you need to read the code below to know what it's about. In GDB, and I suspect in the majority of GNU projects, the comments are place before the code which can force us to repeat the code a bit sometimes... I tried to make a suggestion but I don't know Fortran enough to help. Perhaps: /* Depending on the compiler version being used, the name of the 4-byte integer and real types can be printed differently. For instance, gfortran-4.1 uses "int4" whereas gfortran-4.3 uses "int(kind=4)". */ Dependending on how the information is encoded, the comment can probably be improved further. No need to re-request approval after the comment is expanded a bit. Thanks, -- Joel