Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Emi SUZUKI <emi-suzuki@tjsys.co.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: Watchpoint on an unloaded shared library(1)
Date: Fri, 26 Dec 2008 06:11:00 -0000	[thread overview]
Message-ID: <20081226061055.GA4216@adacore.com> (raw)
In-Reply-To: <20081225.202730.01371998.emi-suzuki@tjsys.co.jp>

> This does work for me, except one duplication of the codes (that you
> may have noticed already):
> 
>   static void
>   do_enable_breakpoint (struct breakpoint *bpt, enum bpdisp disposition)
>   {
>     int target_resources_ok, other_type_used;
>     struct value *mark;
>   
>     if (bpt->type == bp_hardware_breakpoint)

Not quite: As you can see, this part of the code deals with hardware
*breakpoints*, not watchpoints. The code is slightly different because:

>         i = hw_breakpoint_used_count ();

We get the current count of hw breakpoints currently used.

> That should be done in update_watchpoint.  

Except that update_watchpoint only deals with watchpoints :)

> I would try to address incapabilities on PPC after those codes are
> committed.  Thank you for taking care of it!

Er, ... Can you send a patch? I was merely suggesting a different
approach that I hoped would work.

Thank you!
-- 
Joel


  reply	other threads:[~2008-12-26  6:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-20 18:25 Emi SUZUKI
2008-12-13 15:06 ` Joel Brobecker
2008-12-16 12:16   ` Emi SUZUKI
2008-12-21 13:11     ` Joel Brobecker
2008-12-22  3:28       ` Joel Brobecker
2008-12-25 11:28         ` Emi SUZUKI
2008-12-26  6:11           ` Joel Brobecker [this message]
2008-12-26  7:09             ` Emi SUZUKI
2008-12-28 11:48               ` Joel Brobecker
2009-01-06  1:47                 ` Emi SUZUKI
2009-01-06  4:28                   ` Joel Brobecker
2009-01-06  5:16                     ` Emi SUZUKI
2009-01-08  4:02                     ` [commit] " Emi SUZUKI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081226061055.GA4216@adacore.com \
    --to=brobecker@adacore.com \
    --cc=emi-suzuki@tjsys.co.jp \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox