From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16073 invoked by alias); 26 Dec 2008 06:11:41 -0000 Received: (qmail 16065 invoked by uid 22791); 26 Dec 2008 06:11:40 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Dec 2008 06:11:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5DFE02A969A; Fri, 26 Dec 2008 01:11:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q7XLe175ThEx; Fri, 26 Dec 2008 01:11:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9650B2A9697; Fri, 26 Dec 2008 01:11:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1AADCE7ACD; Fri, 26 Dec 2008 10:10:55 +0400 (RET) Date: Fri, 26 Dec 2008 06:11:00 -0000 From: Joel Brobecker To: Emi SUZUKI Cc: gdb-patches@sourceware.org Subject: Re: Watchpoint on an unloaded shared library(1) Message-ID: <20081226061055.GA4216@adacore.com> References: <20081216.211520.207584606.emi-suzuki@tjsys.co.jp> <20081221131036.GB25416@adacore.com> <20081222032758.GA2835@adacore.com> <20081225.202730.01371998.emi-suzuki@tjsys.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081225.202730.01371998.emi-suzuki@tjsys.co.jp> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00411.txt.bz2 > This does work for me, except one duplication of the codes (that you > may have noticed already): > > static void > do_enable_breakpoint (struct breakpoint *bpt, enum bpdisp disposition) > { > int target_resources_ok, other_type_used; > struct value *mark; > > if (bpt->type == bp_hardware_breakpoint) Not quite: As you can see, this part of the code deals with hardware *breakpoints*, not watchpoints. The code is slightly different because: > i = hw_breakpoint_used_count (); We get the current count of hw breakpoints currently used. > That should be done in update_watchpoint. Except that update_watchpoint only deals with watchpoints :) > I would try to address incapabilities on PPC after those codes are > committed. Thank you for taking care of it! Er, ... Can you send a patch? I was merely suggesting a different approach that I hoped would work. Thank you! -- Joel