From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] pre-initialize python-value.c:values_in_python (bug in MacOS linker)
Date: Mon, 08 Dec 2008 17:14:00 -0000 [thread overview]
Message-ID: <20081208171415.GE3823@adacore.com> (raw)
In-Reply-To: <20081205184123.GF5382@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
> 2008-12-05 Joel Brobecker <brobecker@adacore.com>
>
> * python/python-value.c (values_in_python): Add specific initialization
> to NULL to work-around a MacOS linker bug.
Now checked in as attached (added a comment).
--
Joel
[-- Attachment #2: python-value.diff --]
[-- Type: text/plain, Size: 692 bytes --]
Index: python/python-value.c
===================================================================
RCS file: /cvs/src/src/gdb/python/python-value.c,v
retrieving revision 1.5
diff -u -p -r1.5 python-value.c
--- python/python-value.c 28 Oct 2008 17:19:57 -0000 1.5
+++ python/python-value.c 8 Dec 2008 17:12:08 -0000
@@ -30,7 +30,9 @@
can copy the values' types if needed. This is declared
unconditionally to reduce the number of uses of HAVE_PYTHON in the
generic code. */
-struct value *values_in_python;
+/* This variable is unnecessarily initialized to NULL in order to
+ work around a linker bug on MacOS. */
+struct value *values_in_python = NULL;
#ifdef HAVE_PYTHON
prev parent reply other threads:[~2008-12-08 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 18:42 Joel Brobecker
2008-12-05 19:08 ` Tom Tromey
2008-12-06 15:31 ` Mark Kettenis
2008-12-08 15:18 ` Joel Brobecker
2008-12-08 17:14 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208171415.GE3823@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox