From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4545 invoked by alias); 8 Dec 2008 17:14:55 -0000 Received: (qmail 4537 invoked by uid 22791); 8 Dec 2008 17:14:54 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Dec 2008 17:14:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A2EB62A967F for ; Mon, 8 Dec 2008 12:14:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id d-daA2EU5s+k for ; Mon, 8 Dec 2008 12:14:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7140B2A967C for ; Mon, 8 Dec 2008 12:14:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A6F25E7ACD; Mon, 8 Dec 2008 18:14:15 +0100 (CET) Date: Mon, 08 Dec 2008 17:14:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit] pre-initialize python-value.c:values_in_python (bug in MacOS linker) Message-ID: <20081208171415.GE3823@adacore.com> References: <20081205184123.GF5382@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <20081205184123.GF5382@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00152.txt.bz2 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 249 > 2008-12-05 Joel Brobecker > > * python/python-value.c (values_in_python): Add specific initialization > to NULL to work-around a MacOS linker bug. Now checked in as attached (added a comment). -- Joel --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="python-value.diff" Content-length: 692 Index: python/python-value.c =================================================================== RCS file: /cvs/src/src/gdb/python/python-value.c,v retrieving revision 1.5 diff -u -p -r1.5 python-value.c --- python/python-value.c 28 Oct 2008 17:19:57 -0000 1.5 +++ python/python-value.c 8 Dec 2008 17:12:08 -0000 @@ -30,7 +30,9 @@ can copy the values' types if needed. This is declared unconditionally to reduce the number of uses of HAVE_PYTHON in the generic code. */ -struct value *values_in_python; +/* This variable is unnecessarily initialized to NULL in order to + work around a linker bug on MacOS. */ +struct value *values_in_python = NULL; #ifdef HAVE_PYTHON --17pEHd4RhPHOinZp--