Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] pre-initialize python-value.c:values_in_python (bug in MacOS linker)
Date: Sat, 06 Dec 2008 15:31:00 -0000	[thread overview]
Message-ID: <200812061529.mB6FToM6027310@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20081205184123.GF5382@adacore.com> (message from Joel Brobecker 	on Fri, 5 Dec 2008 19:41:23 +0100)

> Date: Fri, 5 Dec 2008 19:41:23 +0100
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hello,
> 
> We noticed that GDB does not build on x86-macos and x86_64-macos when
> configured --without-python (we found this out because one of our
> machine no longer has python installed on it). The problem is that
> the linker complains that it cannot file values_in_python, referenced
> from value.c. This is a bug, since we verified that the symbol was
> defined inside python-value.o which was also part of the archive.
> We think that this might be related to the fact that the symbol is
> defined as "C" (common). We changed the code to add an initial value
> of NULL (which in C is strictly equivalent to the current code),
> which changed our variable to the Data section and, ta da, allowed
> GDB to link.
> 
> 2008-12-05  Joel Brobecker  <brobecker@adacore.com>
> 
>         * python/python-value.c (values_in_python): Add specific initialization
>         to NULL to work-around a MacOS linker bug.
> 
> Tested on x86-linux, both using --with-python and --without-python.
> No regression.
> 
> I think this is pretty safe and safe contained, and doesn't reduce
> the quality of the code, so I'm planning on committing this on Monday
> when back from weekend holiday (I'm in Europe). Any objection? Should
> I add a comment?

Ugh, Yuck.  Any idea if this is fixed in more recent versions of Mac OS X?


  parent reply	other threads:[~2008-12-06 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 18:42 Joel Brobecker
2008-12-05 19:08 ` Tom Tromey
2008-12-06 15:31 ` Mark Kettenis [this message]
2008-12-08 15:18   ` Joel Brobecker
2008-12-08 17:14 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812061529.mB6FToM6027310@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox