Re: [RFA] detect inferior exit in call_function_by_hand

[Pedro Alves <pedro@codesourcery.com>]

On Tuesday 11 November 2008 22:50:20, Doug Evans wrote:
> I found this while playing with the archer exception-rewind branch.
> The message currently printed when the inferior exits during
> call_function_by_hand is misleading.
> [On the branch one currently gets a segv,
> stopped_by_random_signal/stop_stack_dummy do not fully describe
> all the possible states of the inferior.]

Looks OK to me, apart from the tiny issues below.

>  
> +  if (! target_has_execution)
> +    {
> +      /* If we try to restore the inferior status (via the cleanup),
> +	 we'll crash as the inferior is no longer running.  */
> +      discard_cleanups (inf_status_cleanup);
> +      discard_inferior_status (inf_status);
> +      /* FIXME: Insert a bunch of wrap_here; name can be very long if it's
> +	 a C++ name with arguments and stuff.  */

Remove this copy&pasted FIXME note, it doesn't make sense for
this case (you're not printing a function name).


> +      error (_("\
> +The program being debugged exited while in a function called from GDB."));
> +    }
> +
>    if (stopped_by_random_signal || !stop_stack_dummy)
>      {
>        /* Find the name of the function we're about to complain about.  */


> +
> +if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
> +     untested callfuncs.exp
                    ^^^^ ECOPYPASTE (callexit.exp)

> +     return -1


> +# Set the current language to C.  This counts as a test.  If it
> +# fails, then we skip the other tests.
> +

I don't know why all the infcalls tests do this --- they
all seem to do it.  Do you/anyone know(s) why?

> +proc set_lang_c {} {
> +    global gdb_prompt
> +
> +    send_gdb "set language c\n"
> +    gdb_expect {
> +	-re ".*$gdb_prompt $" {}
> +	timeout { fail "set language c (timeout)" ; return 0; }
> +    }
> +
> +    send_gdb "show language\n"
> +    gdb_expect {
> +	-re ".* source language is \"c\".*$gdb_prompt $" {
> +	    pass "set language to \"c\""
> +	    return 1
> +	}
> +	-re ".*$gdb_prompt $" {
> +	    fail "setting language to \"c\""
> +	    return 0
> +	}
> +	timeout {
> +	    fail "can't show language (timeout)"
> +	    return 0
> +	}
> +    }
> +}
> +
> +# Start with a fresh gdb.
> +
> +gdb_exit
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +

> +if { ![set_lang_c] } {
> +    gdb_suppress_tests;
> +} else {
> +    if { ![runto_main] } {
> +	gdb_suppress_tests;
> +    }
> +}
> +

-- 
Pedro Alves