Re: [RFA] fix win32-nat failure

[Pedro Alves <pedro@codesourcery.com>]

On Thursday 02 October 2008 12:53:44, Pierre Muller wrote:
> I ran a testsuite on cygwin with the patch below,
> I got this results:
> 
>                 === gdb Summary ===
> 
> # of expected passes            11190
> # of unexpected failures        469
> # of expected failures          58
> # of unknown successes          2
> # of known failures             110
> # of unresolved testcases       40
> # of untested testcases         15
> # of unsupported tests          23
> /usr/local/src/gdbcvs/build-bare/gdb/testsuite/../../gdb/gdb version
> 6.8.50.200
> 81002-cvs -nx
> 
> This seems like a "normal" outcome for cygwin native gdb.

Hmmm, I don't have a good baseline stored to compare this to, but, from
memory, this looks worse than is was a few weeks ago...  The failure count
should be much lower currently, due to both the fix that forced unbuffered
stdout on Cygwin, and the skip __main fix.

Oh, I'm running the testsuite too, and I'm getting several crashes
like these, which I had never seen before:

 $ ./gdb /home/pedro/gdb/baseline/build/gdb/testsuite/gdb.cp/class2
 GNU gdb (GDB) 6.8.50.20081002-cvs
 Copyright (C) 2008 Free Software Foundation, Inc.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 This is free software: you are free to change and redistribute it.
 There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
 and "show warranty" for details.
 This GDB was configured as "i686-pc-cygwin".
 For bug reporting instructions, please see:
 <http://www.gnu.org/software/gdb/bugs/>...
 BFD: BFD (GNU Binutils) 2.19.50.20081002 internal error, aborting at ../../src/bfd/coffcode.h line 842 in handle_COMDAT

 BFD: Please report this bug.

This is with stock gcc and binutils.  Looks like something
broke recently on the binutils/bfd side...

> Thus I would like to get approval for the following patch,
> ChangeLog entry:
> 
> 2008-10-02  Pierre Muller  <muller@ics.u-strasbg.fr>
> 		Pedro Alves  <pedro@codesourcery.com>
> 
> 	* win32-nat.c (do_initial_win32_stuff): Set inferior_ptid.

We're doing a small adjustment that I should have made myself,
due to new core expectations, so I don't think we don't need to
bother Christopher with this one.

OK.  Please check it in.

Thanks!

-- 
Pedro Alves