From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: [RFA] fix win32-nat failure
Date: Thu, 02 Oct 2008 11:58:00 -0000 [thread overview]
Message-ID: <00b701c92485$8bc23260$a3469720$@u-strasbg.fr> (raw)
In-Reply-To: <009a01c9246a$64ece5b0$2ec6b110$@u-strasbg.fr>
I ran a testsuite on cygwin with the patch below,
I got this results:
=== gdb Summary ===
# of expected passes 11190
# of unexpected failures 469
# of expected failures 58
# of unknown successes 2
# of known failures 110
# of unresolved testcases 40
# of untested testcases 15
# of unsupported tests 23
/usr/local/src/gdbcvs/build-bare/gdb/testsuite/../../gdb/gdb version
6.8.50.200
81002-cvs -nx
make: *** [check] Error 1
This seems like a "normal" outcome for cygwin native gdb.
Thus I would like to get approval for the following patch,
Pierre Muller
Pascal language support maintainer for GDB
ChangeLog entry:
2008-10-02 Pierre Muller <muller@ics.u-strasbg.fr>
Pedro Alves <pedro@codesourcery.com>
* win32-nat.c (do_initial_win32_stuff): Set inferior_ptid.
Index: gdb/win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.164
diff -u -p -r1.164 win32-nat.c
--- gdb/win32-nat.c 22 Sep 2008 15:21:30 -0000 1.164
+++ gdb/win32-nat.c 2 Oct 2008 08:59:25 -0000
@@ -1550,6 +1550,12 @@ do_initial_win32_stuff (DWORD pid, int a
inf = add_inferior (pid);
inf->attach_flag = attaching;
+ /* Make the new process the current inferior, so terminal handling
+ can rely on it. When attaching, we don't know about any thread
+ id here, but that's OK --- nothing should be referencing the
+ current thread until we report an event out of win32_wait. */
+ inferior_ptid = pid_to_ptid (pid);
+
terminal_init_inferior_with_pgrp (pid);
target_terminal_inferior ();
next prev parent reply other threads:[~2008-10-02 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 12:25 [RFC] " Pierre Muller
2008-10-01 12:50 ` Pedro Alves
2008-10-01 18:10 ` Pedro Alves
2008-10-02 8:41 ` Pierre Muller
2008-10-02 11:58 ` Pierre Muller [this message]
2008-10-02 13:02 ` [RFA] " Pedro Alves
2008-10-02 14:22 ` Pierre Muller
2008-10-02 15:25 ` Christopher Faylor
2008-10-02 15:54 ` Pedro Alves
2008-10-02 19:07 ` Christopher Faylor
2008-10-02 12:12 ` [RFC] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b701c92485$8bc23260$a3469720$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox