Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] expose gdb values to python
Date: Fri, 26 Sep 2008 20:57:00 -0000	[thread overview]
Message-ID: <20080926205711.GA15215@caradoc.them.org> (raw)
In-Reply-To: <gbhfl6$34b$1@ger.gmane.org>

On Thu, Sep 25, 2008 at 10:59:26PM -0300, Thiago Jung Bauermann wrote:
> This version has no FIXMEs. It uses current_language for value printing, and
> its length operation always fails with NotImplemented. Ok to commit?

Once Eli is happy with the documentation this is OK.

Two coding notes:

> +      PyErr_SetString (PyExc_MemoryError, _("Could not allocate memory to " \
> +					    "create Value object."));

No need for the backslash here.

> +  gdb_test_multiple "python argv = gdb.get_value_from_history (0)" "" {
> +      -re "Traceback.*$gdb_prompt $"  {fail "get value from history"}
> +      -re "$gdb_prompt $"	      {}
> +  }

You really want a helper function for tests expected not to produce
output, they're the bulk of this file.  Another way to do it is by
matching the command as it is sent; that's how the MI tests work.
I think there's some non-MI examples too but I'm not sure where.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2008-09-26 20:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12  6:05 Thiago Jung Bauermann
2008-09-20 21:29 ` Tom Tromey
2008-09-21  4:27   ` Daniel Jacobowitz
2008-09-25  4:33     ` Thiago Jung Bauermann
2008-09-25 11:47       ` Daniel Jacobowitz
2008-09-26  2:00         ` Thiago Jung Bauermann
2008-09-26  9:30           ` Eli Zaretskii
2008-09-28  1:19             ` Thiago Jung Bauermann
2008-09-28 18:19               ` Eli Zaretskii
2008-09-29 16:16                 ` Thiago Jung Bauermann
2008-09-29 17:00                   ` Daniel Jacobowitz
2008-09-30  4:07                     ` Thiago Jung Bauermann
2008-09-30 12:41                       ` Daniel Jacobowitz
2008-10-01  3:18                         ` Thiago Jung Bauermann
2008-10-01 11:40                           ` Daniel Jacobowitz
2008-09-29 18:52                   ` Eli Zaretskii
2008-09-26 20:57           ` Daniel Jacobowitz [this message]
2008-10-01  5:39           ` Joel Brobecker
2008-10-04 22:14             ` Thiago Jung Bauermann
2008-09-25  4:49   ` Thiago Jung Bauermann
2008-09-26 23:08     ` Tom Tromey
2008-10-01  5:48   ` Joel Brobecker
2008-10-01 15:12     ` Tom Tromey
2008-10-01 16:04       ` Joel Brobecker
2008-10-04 22:21       ` Daniel Jacobowitz
2008-10-05  0:00         ` Tom Tromey
2008-10-06 18:49           ` Joel Brobecker
2008-10-06 21:15           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080926205711.GA15215@caradoc.them.org \
    --to=drow@false.org \
    --cc=bauerman@br.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox