From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20548 invoked by alias); 26 Sep 2008 20:57:53 -0000 Received: (qmail 20540 invoked by uid 22791); 26 Sep 2008 20:57:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Sep 2008 20:57:13 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 199D610CF4; Fri, 26 Sep 2008 20:57:12 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D556F10CE6; Fri, 26 Sep 2008 20:57:11 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KjKND-0004KB-9Y; Fri, 26 Sep 2008 16:57:11 -0400 Date: Fri, 26 Sep 2008 20:57:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc] expose gdb values to python Message-ID: <20080926205711.GA15215@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , gdb-patches@sources.redhat.com References: <1221199426.24580.26.camel@localhost.localdomain> <20080921042657.GB29631@caradoc.them.org> <20080925114659.GA30878@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00525.txt.bz2 On Thu, Sep 25, 2008 at 10:59:26PM -0300, Thiago Jung Bauermann wrote: > This version has no FIXMEs. It uses current_language for value printing, and > its length operation always fails with NotImplemented. Ok to commit? Once Eli is happy with the documentation this is OK. Two coding notes: > + PyErr_SetString (PyExc_MemoryError, _("Could not allocate memory to " \ > + "create Value object.")); No need for the backslash here. > + gdb_test_multiple "python argv = gdb.get_value_from_history (0)" "" { > + -re "Traceback.*$gdb_prompt $" {fail "get value from history"} > + -re "$gdb_prompt $" {} > + } You really want a helper function for tests expected not to produce output, they're the bulk of this file. Another way to do it is by matching the command as it is sent; that's how the MI tests work. I think there's some non-MI examples too but I'm not sure where. -- Daniel Jacobowitz CodeSourcery