Re: gdb sources

["André Pönitz" <apoenitz@trolltech.com>]

On Friday 19 September 2008 17:25:50 Daniel Jacobowitz wrote:
> On Fri, Sep 19, 2008 at 05:20:13PM +0200, André Pönitz wrote:
> > > Please use diff -up for patches; with the default diff arguments, it's
> > > impossible to see what you've changed.
> > 
> > I intented to do that but I somehow fumbled. Next try attached.
> 
> Sorry, one more issue I didn't mention - please keep changelog entries
> as plain text, not a patch.  They always conflict.
> 
> > @@ -1,3 +1,18 @@
> > +
> > +2008-09-19  Andre Poenitz  <apoenitz@trolltech.com>
> > +
> > +	* symfile.c (allocate_symtab,allocate_psymtab): Accept a const argument.
> > +	(allocate_psymtab): Likewise.
> > +	(free_named_symtabs): Likewise.
> > +	(deduce_language_from_filename): Likewise.
> > +
> > +	* symfile.h (allocate_symtab): Update prototype.
> > +	(allocate_psymtab): Likewise.
> > +	(free_named_symtabs): Likewise.
> > +	* symtab.h (deduce_language_from_filename): Likewise.
> 
> It looks like you started rewriting this entry but didn't finish?

Not really. It's symfile.h in the beginning, and symtab.h in the end. 

There's precedence for having no empty lines in the file contents 
below, also for mixed (with and without empty lines) style within a
single Changelog entry, so I figured having no line might be 
prefered if the stuff belongs close together (as in "Likewise,") and 
an empty line belong where the differences are bigger (if they are
bigger in this case...)

Incidentally, sticking to rules would be much easier if there were
a blurb on the do's or don't's somewhere.

Andre'