Re: gdb sources

[Daniel Jacobowitz <drow@false.org>]

On Fri, Sep 19, 2008 at 05:45:40PM +0200, André Pönitz wrote:
> > > +2008-09-19  Andre Poenitz  <apoenitz@trolltech.com>
> > > +
> > > +	* symfile.c (allocate_symtab,allocate_psymtab): Accept a const argument.
> > > +	(allocate_psymtab): Likewise.
> > > +	(free_named_symtabs): Likewise.
> > > +	(deduce_language_from_filename): Likewise.
> > > +
> > > +	* symfile.h (allocate_symtab): Update prototype.
> > > +	(allocate_psymtab): Likewise.
> > > +	(free_named_symtabs): Likewise.
> > > +	* symtab.h (deduce_language_from_filename): Likewise.
> > 
> > It looks like you started rewriting this entry but didn't finish?
> 
> Not really. It's symfile.h in the beginning, and symtab.h in the end. 

Here's what I meant:

2008-09-19  Andre Poenitz  <apoenitz@trolltech.com>

	* symfile.c (allocate_symtab, allocate_psymtab, free_named_symtabs)
	(deduce_language_from_filename): Accept a const argument.
	* symfile.h (allocate_symtab, allocate_psymtab)
	(free_named_symtabs): Update prototypes.
	* symtab.h (deduce_language_from_filename): Likewise.

> There's precedence for having no empty lines in the file contents 
> below, also for mixed (with and without empty lines) style within a
> single Changelog entry, so I figured having no line might be 
> prefered if the stuff belongs close together (as in "Likewise,") and 
> an empty line belong where the differences are bigger (if they are
> bigger in this case...)

Right - I wouldn't personally put the empty lines where you did, but
there's nothing wrong with it either.

> Incidentally, sticking to rules would be much easier if there were
> a blurb on the do's or don't's somewhere.

In most cases - including this one - we defer to the GNU Coding
Standards document which is available on gnu.org.

-- 
Daniel Jacobowitz
CodeSourcery