From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16950 invoked by alias); 19 Sep 2008 16:25:36 -0000 Received: (qmail 16932 invoked by uid 22791); 19 Sep 2008 16:25:35 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 19 Sep 2008 16:24:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9DA27104AC; Fri, 19 Sep 2008 16:24:54 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 6DD921049B; Fri, 19 Sep 2008 16:24:54 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Kgimr-0001rq-Sz; Fri, 19 Sep 2008 12:24:53 -0400 Date: Fri, 19 Sep 2008 16:25:00 -0000 From: Daniel Jacobowitz To: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= Cc: gdb-patches@sources.redhat.com Subject: Re: gdb sources Message-ID: <20080919162453.GA7120@caradoc.them.org> Mail-Followup-To: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , gdb-patches@sources.redhat.com References: <200809121713.09226.apoenitz@trolltech.com> <200809191720.17336.apoenitz@trolltech.com> <20080919152550.GA3593@caradoc.them.org> <200809191745.41960.apoenitz@trolltech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200809191745.41960.apoenitz@trolltech.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00416.txt.bz2 On Fri, Sep 19, 2008 at 05:45:40PM +0200, André Pönitz wrote: > > > +2008-09-19 Andre Poenitz > > > + > > > + * symfile.c (allocate_symtab,allocate_psymtab): Accept a const argument. > > > + (allocate_psymtab): Likewise. > > > + (free_named_symtabs): Likewise. > > > + (deduce_language_from_filename): Likewise. > > > + > > > + * symfile.h (allocate_symtab): Update prototype. > > > + (allocate_psymtab): Likewise. > > > + (free_named_symtabs): Likewise. > > > + * symtab.h (deduce_language_from_filename): Likewise. > > > > It looks like you started rewriting this entry but didn't finish? > > Not really. It's symfile.h in the beginning, and symtab.h in the end. Here's what I meant: 2008-09-19 Andre Poenitz * symfile.c (allocate_symtab, allocate_psymtab, free_named_symtabs) (deduce_language_from_filename): Accept a const argument. * symfile.h (allocate_symtab, allocate_psymtab) (free_named_symtabs): Update prototypes. * symtab.h (deduce_language_from_filename): Likewise. > There's precedence for having no empty lines in the file contents > below, also for mixed (with and without empty lines) style within a > single Changelog entry, so I figured having no line might be > prefered if the stuff belongs close together (as in "Likewise,") and > an empty line belong where the differences are bigger (if they are > bigger in this case...) Right - I wouldn't personally put the empty lines where you did, but there's nothing wrong with it either. > Incidentally, sticking to rules would be much easier if there were > a blurb on the do's or don't's somewhere. In most cases - including this one - we defer to the GNU Coding Standards document which is available on gnu.org. -- Daniel Jacobowitz CodeSourcery