From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29730 invoked by alias); 19 Sep 2008 15:46:19 -0000 Received: (qmail 29721 invoked by uid 22791); 19 Sep 2008 15:46:19 -0000 X-Spam-Check-By: sourceware.org Received: from smtp.nokia.com (HELO mgw-mx03.nokia.com) (192.100.122.230) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 19 Sep 2008 15:45:44 +0000 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx03.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id m8JFjX36031320 for ; Fri, 19 Sep 2008 18:45:40 +0300 Received: from vaebh102.NOE.Nokia.com ([10.160.244.23]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 19 Sep 2008 18:45:33 +0300 Received: from gar.local ([172.25.167.168]) by vaebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Fri, 19 Sep 2008 18:45:28 +0300 From: =?iso-8859-1?q?Andr=E9_P=F6nitz?= To: gdb-patches@sources.redhat.com Subject: Re: gdb sources Date: Fri, 19 Sep 2008 15:46:00 -0000 User-Agent: KMail/1.9.9 References: <200809121713.09226.apoenitz@trolltech.com> <200809191720.17336.apoenitz@trolltech.com> <20080919152550.GA3593@caradoc.them.org> In-Reply-To: <20080919152550.GA3593@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200809191745.41960.apoenitz@trolltech.com> X-Nokia-AV: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00415.txt.bz2 On Friday 19 September 2008 17:25:50 Daniel Jacobowitz wrote: > On Fri, Sep 19, 2008 at 05:20:13PM +0200, Andr=E9 P=F6nitz wrote: > > > Please use diff -up for patches; with the default diff arguments, it's > > > impossible to see what you've changed. > >=20 > > I intented to do that but I somehow fumbled. Next try attached. >=20 > Sorry, one more issue I didn't mention - please keep changelog entries > as plain text, not a patch. They always conflict. >=20 > > @@ -1,3 +1,18 @@ > > + > > +2008-09-19 Andre Poenitz > > + > > + * symfile.c (allocate_symtab,allocate_psymtab): Accept a const argume= nt. > > + (allocate_psymtab): Likewise. > > + (free_named_symtabs): Likewise. > > + (deduce_language_from_filename): Likewise. > > + > > + * symfile.h (allocate_symtab): Update prototype. > > + (allocate_psymtab): Likewise. > > + (free_named_symtabs): Likewise. > > + * symtab.h (deduce_language_from_filename): Likewise. >=20 > It looks like you started rewriting this entry but didn't finish? Not really. It's symfile.h in the beginning, and symtab.h in the end.=20 There's precedence for having no empty lines in the file contents=20 below, also for mixed (with and without empty lines) style within a single Changelog entry, so I figured having no line might be=20 prefered if the stuff belongs close together (as in "Likewise,") and=20 an empty line belong where the differences are bigger (if they are bigger in this case...) Incidentally, sticking to rules would be much easier if there were a blurb on the do's or don't's somewhere. Andre'