From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Thiago Jung Bauermann <bauerman@br.ibm.com>,
Tom Tromey <tromey@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: RFA: fix minor memory leak in symfile.c
Date: Thu, 18 Sep 2008 02:31:00 -0000 [thread overview]
Message-ID: <20080918023103.GA4940@caradoc.them.org> (raw)
In-Reply-To: <20080918010418.GC3651@adacore.com>
On Wed, Sep 17, 2008 at 06:04:18PM -0700, Joel Brobecker wrote:
> > When I added that use of asprintf, I checked that libiberty provides it
> > if the underlying OS doesn't. I thought we could use anything covered by
> > libiberty. Maybe not?
>
> Not sure. I don't think that it is a portability issue, but rather
> to provide an interface where any issues causes an error to be thrown.
> That way, no need to check the pointer returned, nor the status code,
> and thus it's not possible to forget. I think it's the same as xmalloc.
Yes - thus xstrprintf, I believe.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-09-18 2:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 17:00 Tom Tromey
2008-09-13 17:08 ` Daniel Jacobowitz
2008-09-13 17:18 ` Joel Brobecker
2008-09-13 17:58 ` Tom Tromey
2008-09-13 22:35 ` Joel Brobecker
2008-09-13 22:53 ` Tom Tromey
2008-09-13 23:04 ` Joel Brobecker
2008-09-13 23:47 ` Mark Kettenis
2008-09-14 23:09 ` Thiago Jung Bauermann
2008-09-15 0:06 ` Tom Tromey
2008-09-18 1:04 ` Joel Brobecker
2008-09-18 2:31 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918023103.GA4940@caradoc.them.org \
--to=drow@false.org \
--cc=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox