From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: RFA: fix minor memory leak in symfile.c
Date: Sat, 13 Sep 2008 23:47:00 -0000 [thread overview]
Message-ID: <200809132346.m8DNkMwu031441@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20080913230327.GC19625@adacore.com> (message from Joel Brobecker on Sat, 13 Sep 2008 16:03:27 -0700)
> Date: Sat, 13 Sep 2008 16:03:27 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> > My understanding is that on all systems in active use, free(NULL)
> > works fine. Jim Meyering recently removed if (x) free (x) from a
> > bunch of GNU programs...
>
> We might end up doing it in GDB as well, not sure what the others think.
I don't see why we should change our policy to use xfree(), but the
main reason why we didn't rely on free(NULL) doing nothing was SunOS
4. There's probably no point in supporting GDB on that platform
anymore, so I think requiring a C89 libc would be reasonable.
Mark
next prev parent reply other threads:[~2008-09-13 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 17:00 Tom Tromey
2008-09-13 17:08 ` Daniel Jacobowitz
2008-09-13 17:18 ` Joel Brobecker
2008-09-13 17:58 ` Tom Tromey
2008-09-13 22:35 ` Joel Brobecker
2008-09-13 22:53 ` Tom Tromey
2008-09-13 23:04 ` Joel Brobecker
2008-09-13 23:47 ` Mark Kettenis [this message]
2008-09-14 23:09 ` Thiago Jung Bauermann
2008-09-15 0:06 ` Tom Tromey
2008-09-18 1:04 ` Joel Brobecker
2008-09-18 2:31 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809132346.m8DNkMwu031441@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox