From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix minor memory leak in symfile.c
Date: Sat, 13 Sep 2008 17:18:00 -0000 [thread overview]
Message-ID: <20080913171723.GH3714@adacore.com> (raw)
In-Reply-To: <m3bpysugn4.fsf@fleche.redhat.com>
:REVIEWMAIL:
> While auditing other callers of build_id_bfd_get, I found a use of
> 'free', so I fixed that as well. (Perhaps we ought to poison "free"?)
I think that's a good idea, since I don't think there is any case
besides the xfree implementation where we want to call free. Same
for malloc as well. But I'm not very familiar with the pros and
cons of this GCC pragma.
> 2008-09-13 Tom Tromey <tromey@redhat.com>
>
> * symfile.c (build_id_verify): Free 'found'.
> (find_separate_debug_file): Use xfree, not free.
Looks good :).
--
Joel
next prev parent reply other threads:[~2008-09-13 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 17:00 Tom Tromey
2008-09-13 17:08 ` Daniel Jacobowitz
2008-09-13 17:18 ` Joel Brobecker [this message]
2008-09-13 17:58 ` Tom Tromey
2008-09-13 22:35 ` Joel Brobecker
2008-09-13 22:53 ` Tom Tromey
2008-09-13 23:04 ` Joel Brobecker
2008-09-13 23:47 ` Mark Kettenis
2008-09-14 23:09 ` Thiago Jung Bauermann
2008-09-15 0:06 ` Tom Tromey
2008-09-18 1:04 ` Joel Brobecker
2008-09-18 2:31 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913171723.GH3714@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox