Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
		gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [rfc] add ppc testcase to test fpscr
Date: Wed, 03 Sep 2008 21:01:00 -0000	[thread overview]
Message-ID: <20080903210054.GA8670@caradoc.them.org> (raw)
In-Reply-To: <1220472745.9671.13.camel@localhost.localdomain>

On Wed, Sep 03, 2008 at 05:12:25PM -0300, Thiago Jung Bauermann wrote:
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {quiet debug additional_flags=-O0}] != "" } {

No need for additional_flags here.

> +# Run the program, when the prompt comes back it will be for the invalid
> +# operation breakpoint.
> +gdb_run_cmd

You've got to wait for the prompt explicitly.  If you ever leave expect
in a state where two prompts should be arriving, it won't know which
is which; if it sees them separately, you can get out of sync and all
tests will fail with unknown output.  That's one advantage of using
runto_main followed by an explicit continue.

Looks otherwise OK to me.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-09-03 21:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 23:18 Thiago Jung Bauermann
2008-08-21 23:32 ` Daniel Jacobowitz
2008-08-21 23:42   ` Thiago Jung Bauermann
2008-08-22  2:47     ` Daniel Jacobowitz
2008-08-22 18:13       ` Thiago Jung Bauermann
2008-09-02 21:40         ` Joel Brobecker
2008-09-02 23:35           ` Thiago Jung Bauermann
2008-09-02 23:46             ` Daniel Jacobowitz
2008-09-02 21:55         ` Daniel Jacobowitz
2008-09-03 20:15           ` Thiago Jung Bauermann
2008-09-03 21:01             ` Daniel Jacobowitz [this message]
2008-09-04  1:26               ` Thiago Jung Bauermann
2008-09-05  0:12                 ` Joel Brobecker
2008-09-05  3:38                   ` Thiago Jung Bauermann
2008-09-05 14:00                     ` Joel Brobecker
2008-09-05 19:30                       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080903210054.GA8670@caradoc.them.org \
    --to=drow@false.org \
    --cc=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox