From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31784 invoked by alias); 3 Sep 2008 21:01:37 -0000 Received: (qmail 31776 invoked by uid 22791); 3 Sep 2008 21:01:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 Sep 2008 21:00:58 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DB60398417; Wed, 3 Sep 2008 21:00:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A1A579809F; Wed, 3 Sep 2008 21:00:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KazTC-0002Gh-Qe; Wed, 03 Sep 2008 17:00:54 -0400 Date: Wed, 03 Sep 2008 21:01:00 -0000 From: Daniel Jacobowitz To: Thiago Jung Bauermann Cc: Joel Brobecker , gdb-patches ml Subject: Re: [rfc] add ppc testcase to test fpscr Message-ID: <20080903210054.GA8670@caradoc.them.org> Mail-Followup-To: Thiago Jung Bauermann , Joel Brobecker , gdb-patches ml References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> <20080902215458.GB25623@caradoc.them.org> <1220472745.9671.13.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220472745.9671.13.camel@localhost.localdomain> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00054.txt.bz2 On Wed, Sep 03, 2008 at 05:12:25PM -0300, Thiago Jung Bauermann wrote: > +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {quiet debug additional_flags=-O0}] != "" } { No need for additional_flags here. > +# Run the program, when the prompt comes back it will be for the invalid > +# operation breakpoint. > +gdb_run_cmd You've got to wait for the prompt explicitly. If you ever leave expect in a state where two prompts should be arriving, it won't know which is which; if it sees them separately, you can get out of sync and all tests will fail with unknown output. That's one advantage of using runto_main followed by an explicit continue. Looks otherwise OK to me. -- Daniel Jacobowitz CodeSourcery