From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [rfc] add ppc testcase to test fpscr
Date: Tue, 02 Sep 2008 21:40:00 -0000 [thread overview]
Message-ID: <20080902213949.GH3774@adacore.com> (raw)
In-Reply-To: <1219428669.8167.2.camel@localhost.localdomain>
> 2008-08-22 Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> Add FPSCR tests.
>
> * gdb.arch/ppc-fp.exp: New file.
> * gdb.arch/ppc-fp.c: New file.
I didn't see anyone actually review the patch so I took a look.
Looks OK to me, but I'm really wonderng why you added a '\r' at
the end of the expected output in our gdb_test calls. For instance:
> +gdb_test "print \$fpscr" " = 0\r" "FPSCR is all zeroes"
Usually, I just do:
gdb_test "print \$fpscr" " = 0" "FPSCR is all zeroes"
Is there something specific that you are trying to do with the '\r'?
> +#include <stdio.h>
Is the use of stdio necessary in this case. If you can do without,
then this would allow us to run this testcase in the bareboard case
(powerpc-elf). Not strictly necessary, but nice to have...
--
Joel
next prev parent reply other threads:[~2008-09-02 21:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 23:18 Thiago Jung Bauermann
2008-08-21 23:32 ` Daniel Jacobowitz
2008-08-21 23:42 ` Thiago Jung Bauermann
2008-08-22 2:47 ` Daniel Jacobowitz
2008-08-22 18:13 ` Thiago Jung Bauermann
2008-09-02 21:40 ` Joel Brobecker [this message]
2008-09-02 23:35 ` Thiago Jung Bauermann
2008-09-02 23:46 ` Daniel Jacobowitz
2008-09-02 21:55 ` Daniel Jacobowitz
2008-09-03 20:15 ` Thiago Jung Bauermann
2008-09-03 21:01 ` Daniel Jacobowitz
2008-09-04 1:26 ` Thiago Jung Bauermann
2008-09-05 0:12 ` Joel Brobecker
2008-09-05 3:38 ` Thiago Jung Bauermann
2008-09-05 14:00 ` Joel Brobecker
2008-09-05 19:30 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902213949.GH3774@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox