From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27915 invoked by alias); 2 Sep 2008 21:40:30 -0000 Received: (qmail 27859 invoked by uid 22791); 2 Sep 2008 21:40:30 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 21:39:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 820E12A969F; Tue, 2 Sep 2008 17:39:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yvNsQrJOP0FA; Tue, 2 Sep 2008 17:39:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3DFC52A965E; Tue, 2 Sep 2008 17:39:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8F2FDE7ACD; Tue, 2 Sep 2008 23:39:49 +0200 (CEST) Date: Tue, 02 Sep 2008 21:40:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [rfc] add ppc testcase to test fpscr Message-ID: <20080902213949.GH3774@adacore.com> References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1219428669.8167.2.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00026.txt.bz2 > 2008-08-22 Thiago Jung Bauermann > > Add FPSCR tests. > > * gdb.arch/ppc-fp.exp: New file. > * gdb.arch/ppc-fp.c: New file. I didn't see anyone actually review the patch so I took a look. Looks OK to me, but I'm really wonderng why you added a '\r' at the end of the expected output in our gdb_test calls. For instance: > +gdb_test "print \$fpscr" " = 0\r" "FPSCR is all zeroes" Usually, I just do: gdb_test "print \$fpscr" " = 0" "FPSCR is all zeroes" Is there something specific that you are trying to do with the '\r'? > +#include Is the use of stdio necessary in this case. If you can do without, then this would allow us to run this testcase in the bareboard case (powerpc-elf). Not strictly necessary, but nice to have... -- Joel