From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: Use is_stopped, instead of !is_running
Date: Sat, 16 Aug 2008 23:54:00 -0000 [thread overview]
Message-ID: <200808170054.07199.pedro@codesourcery.com> (raw)
In-Reply-To: <20080809143045.GC4936@adacore.com>
On Saturday 09 August 2008 15:30:45, Joel Brobecker wrote:
> > 2008-07-29 Pedro Alves <pedro@codesourcery.com>
> >
> > * gdbthread.h: Add comments.
> > * stack.c (get_selected_block): Return 0 on an exited thread.
> > * top.c (execute_command): Check for is_stopped, not !is_running.
> > * event-top.c (command_handler): Likewise.
>
> Looks OK to me. It took me a while to decide that it was OK to leave
> one instance inside inf-loop.c, but I think the !is_running there is OK.
Yeah, it actually also took me a while to decide what to do with that
check, and it's just for a log printf.
Thanks, Joel, I checked it in. I'm posting an internal docs blurb
about these states next.
--
Pedro Alves
prev parent reply other threads:[~2008-08-16 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 13:59 Pedro Alves
2008-07-29 15:59 ` Thiago Jung Bauermann
2008-07-29 16:32 ` Pedro Alves
2008-08-09 14:31 ` Joel Brobecker
2008-08-16 23:54 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808170054.07199.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox