From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Use is_stopped, instead of !is_running
Date: Tue, 29 Jul 2008 15:59:00 -0000 [thread overview]
Message-ID: <1217347148.5842.7.camel@localhost.localdomain> (raw)
In-Reply-To: <200807291459.12056.pedro@codesourcery.com>
On Tue, 2008-07-29 at 14:59 +0100, Pedro Alves wrote:
> I'm adding more comments to gdbthread.h to describe why. Basically,
> the thread state is not a boolean anymore.
If the thread state is not a boolean, then IMHO offering convenient
functions which treat it as such and then putting a warning in the
comment is really setting up a subtle trap for GDB hackers... :-)
What about just nuking is_running and is_stopping, and making everybody
use is_thread_state directly? That would make this reality explicit.
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-07-29 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 13:59 Pedro Alves
2008-07-29 15:59 ` Thiago Jung Bauermann [this message]
2008-07-29 16:32 ` Pedro Alves
2008-08-09 14:31 ` Joel Brobecker
2008-08-16 23:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217347148.5842.7.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox