From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29517 invoked by alias); 29 Jul 2008 15:59:37 -0000 Received: (qmail 29509 invoked by uid 22791); 29 Jul 2008 15:59:37 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 29 Jul 2008 15:59:15 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw1.br.ibm.com (Postfix) with ESMTP id 2097032C11E for ; Tue, 29 Jul 2008 12:31:05 -0300 (BRT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m6TFxE3b598040 for ; Tue, 29 Jul 2008 12:59:15 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6TFx8IP002231 for ; Tue, 29 Jul 2008 12:59:09 -0300 Received: from [9.18.238.102] ([9.18.238.102]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m6TFx8BZ002174; Tue, 29 Jul 2008 12:59:08 -0300 Subject: Re: Use is_stopped, instead of !is_running From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org In-Reply-To: <200807291459.12056.pedro@codesourcery.com> References: <200807291459.12056.pedro@codesourcery.com> Content-Type: text/plain Date: Tue, 29 Jul 2008 15:59:00 -0000 Message-Id: <1217347148.5842.7.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00542.txt.bz2 On Tue, 2008-07-29 at 14:59 +0100, Pedro Alves wrote: > I'm adding more comments to gdbthread.h to describe why. Basically, > the thread state is not a boolean anymore. If the thread state is not a boolean, then IMHO offering convenient functions which treat it as such and then putting a warning in the comment is really setting up a subtle trap for GDB hackers... :-) What about just nuking is_running and is_stopping, and making everybody use is_thread_state directly? That would make this reality explicit. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center