From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32731 invoked by alias); 16 Aug 2008 23:54:23 -0000 Received: (qmail 32723 invoked by uid 22791); 16 Aug 2008 23:54:22 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 16 Aug 2008 23:53:39 +0000 Received: (qmail 9509 invoked from network); 16 Aug 2008 23:53:37 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Aug 2008 23:53:37 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Use is_stopped, instead of !is_running Date: Sat, 16 Aug 2008 23:54:00 -0000 User-Agent: KMail/1.9.9 Cc: Joel Brobecker References: <200807291459.12056.pedro@codesourcery.com> <20080809143045.GC4936@adacore.com> In-Reply-To: <20080809143045.GC4936@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808170054.07199.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00459.txt.bz2 On Saturday 09 August 2008 15:30:45, Joel Brobecker wrote: > > 2008-07-29 Pedro Alves > > > > * gdbthread.h: Add comments. > > * stack.c (get_selected_block): Return 0 on an exited thread. > > * top.c (execute_command): Check for is_stopped, not !is_running. > > * event-top.c (command_handler): Likewise. > > Looks OK to me. It took me a while to decide that it was OK to leave > one instance inside inf-loop.c, but I think the !is_running there is OK. Yeah, it actually also took me a while to decide what to do with that check, and it's just for a log printf. Thanks, Joel, I checked it in. I'm posting an internal docs blurb about these states next. -- Pedro Alves