From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Remove unnecessary target defaults.
Date: Sat, 16 Aug 2008 20:15:00 -0000 [thread overview]
Message-ID: <20080816201513.GB9401@caradoc.them.org> (raw)
In-Reply-To: <200808151645.31042.vladimir@codesourcery.com>
On Fri, Aug 15, 2008 at 04:45:30PM +0400, Vladimir Prus wrote:
>
> In current GDB, at the bottom of the target stack, we always have dummy
> target, which defines some target methods, including to_create_inferiour,
> and to_attach. Those are implemented by calling find_default_attach
> and find_default_create_inferior, which will call 'error' when nothing
> is found.
>
> On the other hand, update_current_target tries to set a default value
> for those functions -- but because dummy target is always there, such
> defaulting is not necessary. This patch removes it. No regressions on x86.
>
> OK?
>
> - Volodya
>
> * target.c (maybe_kill_then_attach)
> (maybe_kill_then_create_inferior): Remove.
> (update_current_target): Do not default to_attach,
> to_create_inferiour, to_is_async_p.
Based on the discussion, this is OK.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-08-16 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 12:46 Vladimir Prus
2008-08-15 13:08 ` Pedro Alves
2008-08-15 14:16 ` Vladimir Prus
2008-08-15 14:31 ` Pedro Alves
2008-08-15 14:41 ` Vladimir Prus
2008-08-15 14:52 ` Pedro Alves
2008-08-15 15:02 ` Vladimir Prus
2008-08-15 15:11 ` Pedro Alves
2008-08-16 20:15 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080816201513.GB9401@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox