From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17672 invoked by alias); 16 Aug 2008 20:15:55 -0000 Received: (qmail 17658 invoked by uid 22791); 16 Aug 2008 20:15:55 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 16 Aug 2008 20:15:16 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 82657983B4; Sat, 16 Aug 2008 20:15:14 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 50F039839E; Sat, 16 Aug 2008 20:15:14 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KUSB7-0002WD-OZ; Sat, 16 Aug 2008 16:15:13 -0400 Date: Sat, 16 Aug 2008 20:15:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Remove unnecessary target defaults. Message-ID: <20080816201513.GB9401@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200808151645.31042.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808151645.31042.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00452.txt.bz2 On Fri, Aug 15, 2008 at 04:45:30PM +0400, Vladimir Prus wrote: > > In current GDB, at the bottom of the target stack, we always have dummy > target, which defines some target methods, including to_create_inferiour, > and to_attach. Those are implemented by calling find_default_attach > and find_default_create_inferior, which will call 'error' when nothing > is found. > > On the other hand, update_current_target tries to set a default value > for those functions -- but because dummy target is always there, such > defaulting is not necessary. This patch removes it. No regressions on x86. > > OK? > > - Volodya > > * target.c (maybe_kill_then_attach) > (maybe_kill_then_create_inferior): Remove. > (update_current_target): Do not default to_attach, > to_create_inferiour, to_is_async_p. Based on the discussion, this is OK. -- Daniel Jacobowitz CodeSourcery