bsd-uthread, claim the core target's main thread

bsd-uthread, claim the core target's main thread

[Pedro Alves]

Finally,

Since the core_stratum layer is now registering a thread, layers above
should claim it.  This fixes the bsd-uthread target.

It is meanto to be applies on top of this one, 
 http://sourceware.org/ml/gdb-patches/2008-08/msg00295.html

, although it also applies cleanly on top of the patch to make the
bsd-uthread target always register a main thread.

AIX is still needing update or just some checking, to make it always 
register a thread.  The thread syncing in aix-thread.c and its use of
ptid_cmp still looks a bit of a mistery to me to propose a fix.  :-(
The "failure" mode would be that you'd get two entries for the
same thread, with different ptids.

There's isn't any other target that can layer a thread_stratum
target over a core_statum.

OK, when the dependencies are in?

-- 
Pedro Alves

Re: bsd-uthread, claim the core target's main thread

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

Err, ENOPATCH.

I also forgot to mention that this also makes the case of going from:

 - -pthread or -c_r symbols not loaded

to:

 - -pthread  or -c_r symbols loaded

when the inferior is already being debugged, behave properly.  Not a usual use 
case, but previously, we were updating inferior_ptid in bsd_uthreads_wait,
but not here.

On Monday 11 August 2008 15:05:12, Pedro Alves wrote:
> Finally,
>
> Since the core_stratum layer is now registering a thread, layers above
> should claim it.  This fixes the bsd-uthread target.
>
> It is meanto to be applies on top of this one,
>  http://sourceware.org/ml/gdb-patches/2008-08/msg00295.html
>
> , although it also applies cleanly on top of the patch to make the
> bsd-uthread target always register a main thread.
>
> AIX is still needing update or just some checking, to make it always
> register a thread.  The thread syncing in aix-thread.c and its use of
> ptid_cmp still looks a bit of a mistery to me to propose a fix.  :-(
> The "failure" mode would be that you'd get two entries for the
> same thread, with different ptids.
>
> There's isn't any other target that can layer a thread_stratum
> target over a core_statum.
>
> OK, when the dependencies are in?

Here it is.

-- 
Pedro Alves

[-- Attachment #2: bsd-uthread_claim_main_thread.diff --]
[-- Type: text/x-diff, Size: 1002 bytes --]

2008-08-11  Pedro Alves  <pedro@codesourcery.com>

	* bsd-uthread.c (bsd_uthread_find_new_threads): Claim a main
	thread.

---
 gdb/bsd-uthread.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Index: src/gdb/bsd-uthread.c
===================================================================
--- src.orig/gdb/bsd-uthread.c	2008-08-11 13:23:53.000000000 +0100
+++ src/gdb/bsd-uthread.c	2008-08-11 13:25:14.000000000 +0100
@@ -422,7 +422,15 @@ bsd_uthread_find_new_threads (void)
       ptid_t ptid = ptid_build (pid, 0, addr);
 
       if (!in_thread_list (ptid) || is_exited (ptid))
-	add_thread (ptid);
+	{
+	  /* If INFERIOR_PTID doesn't have a tid member yet, then ptid
+	     is still the initial thread of the process.  Notify GDB
+	     core about it.  */
+	  if (ptid_get_tid (inferior_ptid) == 0)
+	    thread_change_ptid (inferior_ptid, ptid);
+	  else
+	    add_thread (ptid);
+	}
 
       addr = read_memory_typed_address (addr + offset,
 					builtin_type_void_data_ptr);

Re: bsd-uthread, claim the core target's main thread

[Daniel Jacobowitz]

On Mon, Aug 11, 2008 at 03:11:42PM +0100, Pedro Alves wrote:
> 2008-08-11  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* bsd-uthread.c (bsd_uthread_find_new_threads): Claim a main
> 	thread.

OK.

-- 
Daniel Jacobowitz
CodeSourcery