From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: Fix building on x86 OpenBSD 4.3
Date: Wed, 06 Aug 2008 15:23:00 -0000 [thread overview]
Message-ID: <200808061520.m76FKwpk014727@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200808061610.44404.pedro@codesourcery.com> (message from Pedro Alves on Wed, 6 Aug 2008 16:10:44 +0100)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 6 Aug 2008 16:10:44 +0100
>
> Hi,
>
> In my testing on several targets, I noticed that GDB isn't
> building on x86 OpenBSD 4.3, due to the fact that struct
> switchframe got its sf_ppl member removed, and GDB is trying
> to access it.
>
> I can't claim I know a think about this, but,
>
> The patch that seems to have removed it, shows that is was always
> 0 just before removal:
>
> http://archive.netbsd.se/?ml=openbsd-tech&a=2007-09&m=5239543
>
> And I can see it being set to != 0 in that files' history at:
> http://opengrok.creo.hu/openbsd/history/src/sys/arch/i386/i386/vm_machdep.c
>
> So, I guess that the attached is the best to do, and I didn't
> notice any breakage. Of course, I don't even know what
> triggers this code path. :-)
>
> Mark, perhaps you have a better fix in your local trees?
Oops, yes I have. Fixed this and never seemed to have committed the
fix when OpenBSD 4.3 was officially released. Need to tweak it such
that the file compiles on older OpenBSD releases though.
Thanks for pointing this out.
next prev parent reply other threads:[~2008-08-06 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 15:11 Pedro Alves
2008-08-06 15:23 ` Mark Kettenis [this message]
2008-08-06 15:28 ` Mark Kettenis
2008-08-06 15:33 ` Pedro Alves
2008-08-06 15:52 ` Mark Kettenis
2008-08-06 20:04 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808061520.m76FKwpk014727@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox