From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18778 invoked by alias); 6 Aug 2008 15:23:25 -0000 Received: (qmail 18769 invoked by uid 22791); 6 Aug 2008 15:23:25 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Aug 2008 15:22:33 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id m76FKw4U014729; Wed, 6 Aug 2008 17:20:58 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id m76FKwpk014727; Wed, 6 Aug 2008 17:20:58 +0200 (CEST) Date: Wed, 06 Aug 2008 15:23:00 -0000 Message-Id: <200808061520.m76FKwpk014727@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: pedro@codesourcery.com CC: gdb-patches@sourceware.org In-reply-to: <200808061610.44404.pedro@codesourcery.com> (message from Pedro Alves on Wed, 6 Aug 2008 16:10:44 +0100) Subject: Re: Fix building on x86 OpenBSD 4.3 References: <200808061610.44404.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00118.txt.bz2 > From: Pedro Alves > Date: Wed, 6 Aug 2008 16:10:44 +0100 > > Hi, > > In my testing on several targets, I noticed that GDB isn't > building on x86 OpenBSD 4.3, due to the fact that struct > switchframe got its sf_ppl member removed, and GDB is trying > to access it. > > I can't claim I know a think about this, but, > > The patch that seems to have removed it, shows that is was always > 0 just before removal: > > http://archive.netbsd.se/?ml=openbsd-tech&a=2007-09&m=5239543 > > And I can see it being set to != 0 in that files' history at: > http://opengrok.creo.hu/openbsd/history/src/sys/arch/i386/i386/vm_machdep.c > > So, I guess that the attached is the best to do, and I didn't > notice any breakage. Of course, I don't even know what > triggers this code path. :-) > > Mark, perhaps you have a better fix in your local trees? Oops, yes I have. Fixed this and never seemed to have committed the fix when OpenBSD 4.3 was officially released. Need to tweak it such that the file compiles on older OpenBSD releases though. Thanks for pointing this out.